Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recompile it for current node/electron version #6

Open
hendrikreimers opened this issue Nov 23, 2019 · 5 comments
Open

Recompile it for current node/electron version #6

hendrikreimers opened this issue Nov 23, 2019 · 5 comments

Comments

@hendrikreimers
Copy link

I'm using v10.16.3+
Please renew it for the latest version and extend the manual on how to do it in future and which requirements needed.
Thanks

@javaarchive
Copy link

Yeah, I'm using node 12 and really don't want to change my node version. I can't compile the binaries as I get this issue

Building the projects in this solution one at a time. To enable parallel build, please add the "-m" switch.
  bindings.cc
  electronwallpaper_win.cc
  win_delay_load_hook.cc
D:\Node\Electron1\node_modules\electron-wallpaper\src\bindings.cc(50,94): error C2661: 'v8::Value::ToObject': no overlo
aded function takes 0 arguments [D:\Node\Electron1\node_modules\electron-wallpaper\build\electron-wallpaper.vcxproj]
D:\Node\Electron1\node_modules\electron-wallpaper\src\bindings.cc(40,60): warning C4996: 'v8::String::NewFromUtf8': was
 declared deprecated [D:\Node\Electron1\node_modules\electron-wallpaper\build\electron-wallpaper.vcxproj]
D:\Node\Electron1\node_modules\electron-wallpaper\src\bindings.cc(45,39): warning C4996: 'v8::String::NewFromUtf8': was
 declared deprecated [D:\Node\Electron1\node_modules\electron-wallpaper\build\electron-wallpaper.vcxproj]
gyp ERR! build error

@SsrCoder
Copy link

SsrCoder commented Aug 2, 2020

I got the same problem

@javaarchive
Copy link

hi there, a fork of electron wallpaper compiles fine for me
https://www.npmjs.com/package/electron-wallpaper-napi

@aofenghanyue
Copy link

hi there, a fork of electron wallpaper compiles fine for me
https://www.npmjs.com/package/electron-wallpaper-napi

thanks! it really works!

@PortalZii
Copy link

hi there, a fork of electron wallpaper compiles fine for me
https://www.npmjs.com/package/electron-wallpaper-napi

AHHHHHH i should of clicked on issues sooner. Bypassed this so many times before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants