Copy gates in LSTM, GRU ops before applying activations #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a workaround until #192 is solved more generally.
robertknight
force-pushed
the
gru-sigmoid-copy
branch
from
cf790fa
to
5819512
Compare
robertknight
changed the title
This change was previously applied in the GRU operator to work around `sigmoid_in_place` and `tanh_in_place` being slow for non-contiguous inputs, which will be the case if the batch size is > 1.
robertknight
force-pushed
the
gru-sigmoid-copy
branch
from
5819512
to
bf848f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the batch size is > 1, slices of the
gatesscratch space to extract specific gates are non-contiguous, which makessigmoid_in_placeandtanh_in_placemuch slower. See #192. The GRU op had a workaround by using the non-in-placetanhinstead. This applies the same solution to the sigmoid activation in the GRU op and all activations in the LSTM op.