Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Does MapboxGL.offlineManager.createPack support custom styles? #3652

Open
vienha opened this issue Oct 11, 2024 · 4 comments
Open

[Bug]: Does MapboxGL.offlineManager.createPack support custom styles? #3652

vienha opened this issue Oct 11, 2024 · 4 comments
Labels
bug 🪲 Something isn't working

Comments

@vienha
Copy link

vienha commented Oct 11, 2024

Mapbox Implementation

Mapbox

Mapbox Version

10.1.31

React Native Version

0.75.4

Platform

iOS, Android

@rnmapbox/maps version

0.75.4

Standalone component to reproduce

 import Mapbox, {
  Camera,
  MapView,
  offlineManager,
  StyleURL,
} from '@rnmapbox/maps';
import React, { useState } from 'react';
import { Button, Dimensions, TextInput } from 'react-native';
Mapbox.setAccessToken('my_token_here');
const OfflineExample = () => {
  const [packName, setPackName] = useState('offlinePack');
  const [showEditTitle, setShowEditTitle] = useState(false);
  const STYLE_URL = 'custom_style_url'
  const CENTER_COORD =[105.928, 21.0087];
  return (
    <>
      <Button
        title="Create Pack"
        onPress={() => {
          const options = {
            name: packName,
            styleURL: STYLE_URL,
            bounds: [
            [105.517826, 20.90185],
            [105.906464, 21.204365],
          ],
            minZoom: 0,
            maxZoom: 17,
            metadata: {
              whatIsThat: 'foo',
            },
          };
          console.log("options", JSON.stringify(options));
          offlineManager.createPack(options, (region, status) =>
            console.log('=> progress callback region:', 'status: ', status),(region,sattus)=>{
               console.log("Lỗi tải gói: " + sattus);
            }
          );
        }}
      />
      <MapView style={{ flex: 1 }} styleURL={STYLE_URL}>
        <Camera zoomLevel={10} centerCoordinate={CENTER_COORD} />
      </MapView>
    </>
  );
};
export default OfflineExample;

Observed behavior and steps to reproduce

When i call the offlineManager.createPack method, I receive the status:

{"completedResourceCount": 0, "completedResourceSize": 0, "erroredResourceCount": 0, "loadedResourceCount": 0, "loadedResourceSize": 0, "name": "offlinePack", "percentage": NaN, "requiredResourceCount": 0, "state": "complete"}

I wonder if rnmapbox supports creating offline packs with custom styles?

Expected behavior

I want to get the following result.

{"completedResourceCount": 1, "completedResourceSize": 23786585, "erroredResourceCount": 0, "loadedResourceCount": 0, "loadedResourceSize": 0, "name": "offlinePack", "percentage": 3.225806451612903, "requiredResourceCount": 31, "state": "active"}

Notes / preliminary analysis

No response

Additional links and references

No response

@vienha vienha added the bug 🪲 Something isn't working label Oct 11, 2024
@github-actions github-actions bot reopened this Oct 11, 2024
@PeterFred
Copy link

I have the same issue

@vienha
Copy link
Author

vienha commented Oct 14, 2024

@PeterFred Have you found a solution to this problem yet?

@PeterFred
Copy link

@veinha unfortunately no. It is holding up our upgrade, as we have it working for Mapbox 8.5.0
We used this implementation with a JSON file which works well in 8.5. But in 10 we are getting the same as you.
https://ospfranco.com/post/2020/08/04/use-the-mapbox-sdk-to-render-any-tile-set/

@huylocit14054
Copy link

Do you happen to have any news on this one?
I use it with a custom style from Maptiler and can not create offline packs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants