Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo Certificate Authority field for private repos #72

Open
stefanha opened this issue Feb 27, 2024 · 2 comments
Open

Repo Certificate Authority field for private repos #72

stefanha opened this issue Feb 27, 2024 · 2 comments

Comments

@stefanha
Copy link

Public repos pass certificate verification using the system's trusted root certificates. Private repos may require a Certificate Authority that is not in the system's trusted root certificates.

Although some users may be able to add CAs system-wide, it is easiest and cleanest to allow setting CAs on a per-repo basis. This way no change system-wide change is necessary in order to use private repos with custom CAs.

The repo.yaml syntax can be extended with a CA string field so users can provide the CA together with the repository information.

@andreabolognani

@stefanha stefanha changed the title Report certificate authority Repo Certificate Authority field for private repos Feb 27, 2024
@rmohr
Copy link
Owner

rmohr commented Jul 11, 2024

If I understand this correctly, we would basically allow setting a CA field in repo.yaml, and then create a custom https client which will only talk to a repo serving a cert form there. Correct?

@stefanha
Copy link
Author

Yes, the HTTPS client would use the repo.yaml's CA for certificate verification. I'm not sure whether the client should exclusively use the CA or the CA is used in addition to the system-wide trusted root certificates.

This way, a private repo that is available via HTTPS with an internal CA will work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants