Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow empty message if from fallback locale #80

Open
AldericWend opened this issue Jan 14, 2020 · 4 comments · May be fixed by #85
Open

Allow empty message if from fallback locale #80

AldericWend opened this issue Jan 14, 2020 · 4 comments · May be fixed by #85
Labels
bug

Comments

@AldericWend
Copy link

Lang.js/src/lang.js

Line 297 in 1d8e091

if (message[subKey]) {

If we have an empty value for a given key in a fallback locale:

'button.tooltip' => ''

and we request Lang.get('button.tooltip') then _getMessage returns 'button.tooltip'.

if (message[subKey] !== undefined) {

solves the problem.
@lsmith77
Copy link

I am facing the issue same.

@rmariuzzo
Copy link
Owner

@lsmith77 or @AldericWend can you prepare a PR for that? Otherwise, will tackle this during the weekend.

lsmith77 added a commit to lsmith77/Lang.js that referenced this issue Feb 8, 2021
@lsmith77
support fallback of empty strings
4a43b3d 
fixes rmariuzzo#80
@lsmith77 lsmith77 linked a pull request Feb 8, 2021 that will close this issue
Open
@GENL
Copy link

GENL commented Mar 6, 2021

I suggest to use Matice: https://github.com/GENL/matice

@rmariuzzo rmariuzzo added the bug label Mar 6, 2021
@rmariuzzo
Copy link
Owner

I suggest to use Matice: https://github.com/GENL/matice

Hi again @GENL!

I saw 3 comments like this one across two repos. Although, matice doesn't have this bug I would suggest to contact me and if you want I could include a reference in the README file of both projects. I don't expect anything in return. wdyt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

support fallback of empty strings lsmith77/Lang.js
4 participants
@lsmith77 @rmariuzzo @AldericWend @GENL