Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement CLI parameters for more precise variant likelihoods of MM/INS/DEL #11

Open
Krannich479 opened this issue Sep 26, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@Krannich479
Copy link
Collaborator

Currently, a random variable decides which modification is introduced at a base position with hardcoded likelihoods of MM=0.8, INS=0.1 and DEL=0.1. There should be a better way to control this via the CLI.

@Krannich479 Krannich479 added the enhancement New feature or request label Sep 26, 2023
@Krannich479 Krannich479 self-assigned this Sep 26, 2023
@Krannich479
Copy link
Collaborator Author

At the same time, introduce longer runs of INDELs, e.g. using a negative exponential length distribution.

@Krannich479
Copy link
Collaborator Author

Reminder that this should be improved. Currently, the likelihood that a MM/INS/DEL is introduced is coupled to an initial overall likelihood of introducing an error at all. This approach is impractical, slow (unnecessary random floats) and gives a false intuition of the individual mutation likelihoods. The overall likelihood of introducing a mutation should be removed. Also, the option to learn error likelihoods from real data was suggested (thanks to @matthuska )

@Krannich479 Krannich479 added this to the v0.3.0 milestone Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant