Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update chakra-ui select widget for multiple #3850

Closed
wants to merge 1 commit into from

Conversation

julianhille
Copy link

This should fix the logic flaw for the case another field opens the select widget with multiple = false instead of undefined.

Fixes #3848

Reasons for making this change

[Please describe them here]

If this is related to existing tickets, include links to them as well. Use the syntax fixes #[issue number] (ex: fixes #123).

If your PR is non-trivial and you'd like to schedule a synchronous review, please add it to the weekly meeting agenda: https://docs.google.com/document/d/12PjTvv21k6LIky6bNQVnsplMLLnmEuypTLQF8a-8Wss/edit

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests. I've run npm run test:update to update snapshots, if needed.
    • I've updated docs if needed
    • I've updated the changelog with a description of the PR
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

This should fix the logic flaw for the case another field opens the select widget with multiple = false instead of undefined.

Fixes rjsf-team#3848
@julianhille
Copy link
Author

This duplicates #3811 not sure which way we want to go.
I could not find a ticket for for this problem and did not look for PRs. #3811 had no ticket and would also fix #3848

@heath-freenome
Copy link
Member

Already fixed in #3811

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chakra-ui select field calculates isMultiple wrong
2 participants