Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename some function to internal with . #54

Open
TanguyBarthelemy opened this issue Jul 9, 2024 · 1 comment
Open

Rename some function to internal with . #54

TanguyBarthelemy opened this issue Jul 9, 2024 · 1 comment

Comments

@TanguyBarthelemy
Copy link
Contributor

Some functions should be renamed with a . because they implement some internal behaviour (not for the user).

Old function New name GitHub link
likelihood .likelihood

rjd3toolkit/R/utils.R

Lines 73 to 82 in e44c1ea

likelihood<-function(nobs, neffectiveobs=NA, nparams=0, ll, adjustedll=NA, aic, aicc, bic, bicc, ssq){
if (is.na(neffectiveobs)) neffectiveobs<-obs
if (is.na(adjustedll)) adjustedll<-ll
return(structure(list(nobs=nobs, neffectiveobs=neffectiveobs, nparams=nparams,
ll=ll, adjustedll=adjustedll,
aic=aic, aicc=aicc, bic=bic, bicc=bicc, ssq=ssq),
class = "JD3_LIKELIHOOD"))
}
tsmoniker .tsmoniker
tsmoniker<-function(source, id){
return(structure(list(source=source, id=id), class=c(JD3_TSMONIKER)))
}
@TanguyBarthelemy
Copy link
Contributor Author

Done in #62

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant