Worker with embeded WorkerDefaults does not implement Worker interface

[taras-turchenko-moc]

Hi guys. I have an issue with river.AddWorker to add an worker. I have added river.WorkerDefaults[WorkerArgs] but it still fails on interface check

Cannot use deleteimages.NewWorker() (type *Worker) as the type Worker[T] Type does not implement Worker[T]
need the method: NextRetry(job *Job[T]) time.Time
have the method: NextRetry(*Job[T]) time.Time

Manually specifying NextRetry method fixes the issue

func (w *Worker) NextRetry(_ *river.Job[WorkerArgs]) time.Time {
  return time.Time{}
}

output of go version

go version go1.22.6 linux/arm64

[bgentry]

Since you didn’t include your worker definition I can’t be certain, but are you by any chance embedding a pointer to WorkerDefaults instead of the plain type?

https://riverqueue.com/docs#job-args-and-workers

[taras-turchenko-moc]

@bgentry Here is a worker. Seems the error occurs because WorkerDefaults doesnt have argument name in NextRetry so overriding that method fixes the issue

type WorkerArgs struct {
	IDs []model.PrimaryKey
}

func (a WorkerArgs) Kind() string {
	return "DeleteImagesJob"
}

func (a WorkerArgs) InsertOpts() river.InsertOpts {
	return river.InsertOpts{
		Queue: worker.QueueDefault,
	}
}

type Worker struct {
  river.WorkerDefaults[WorkerArgs]
}

func NewWorker() *Worker {
  return &Worker{}
}

// Adding this method fixes the issue
func (w *Worker) NextRetry(_ *river.Job[WorkerArgs]) time.Time {
  return time.Time{}
}

func (w *Worker) Work(ctx context.Context, job *river.Job[WorkerArgs]) error {
  return nil
}

[brandur]

Something odd is happening in your environment. I copied your code with only minor modifications and it runs fine. It might not be the worst idea to start from scratch, then add custom code back until you find out what's spurring on the error.

$ mkdir river-repro-563
$ cd river-repro-563
$ go mod init github.com/brandur/river-repro-563
$ go get -u github.com/riverqueue/river
$ touch main.go # add code below

package main

import (
	"context"

	"github.com/riverqueue/river"
)

type WorkerArgs struct {
	IDs []int
}

func (a WorkerArgs) Kind() string {
	return "DeleteImagesJob"
}

func (a WorkerArgs) InsertOpts() river.InsertOpts {
	return river.InsertOpts{
		Queue: river.QueueDefault,
	}
}

type Worker struct {
	river.WorkerDefaults[WorkerArgs]
}

func NewWorker() *Worker {
	return &Worker{}
}

// Commented this out to show it's not needed.
// func (w *Worker) NextRetry(_ *river.Job[WorkerArgs]) time.Time {
// 	return time.Time{}
// }

func (w *Worker) Work(ctx context.Context, job *river.Job[WorkerArgs]) error {
	return nil
}

func main() {
	workers := river.NewWorkers()
	river.AddWorker(workers, NewWorker())
}

[taras-turchenko-moc]

Okay, thank you