clientDecryptionExtensions, bugFix/perf improvement #1313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttillberg
approved these changes
Oct 21, 2024
texuf
force-pushed
the
austin.ellis/k1_b
branch
from
dd1e2a7
to
aa04210
Compare
texuf
force-pushed
the
austin.ellis/k1_b
branch
2 times, most recently
from
a350c78
to
f50ee3a
Compare
texuf
force-pushed
the
austin.ellis/k1_c
branch
from
82cd311
to
35b98ce
Compare
texuf
force-pushed
the
austin.ellis/k1_b
branch
from
f50ee3a
to
30ddd0e
Compare
I have more and larger refactors coming, but this seemed useful to call out participants includes left users, and instantiates a new set every time with joined, invited, and left users. And it is called inside a pretty hot loop. I will optimize the hot loop in an upcoming pr
texuf
force-pushed
the
austin.ellis/k1_c
branch
from
35b98ce
to
1a12580
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have more and larger refactors coming, but this seemed useful to call out
participants includes left users, and instantiates a new set every time with joined, invited, and left users. And it is called inside a pretty hot loop.
I will optimize the hot loop in an upcoming pr