chore: update contributing docs for installation #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HayesGordon
reviewed
Nov 19, 2024
| cd wasm/submodules/rive-runtime/ | ||
| git checkout main | ||
|
|
||
| cd ../../../js |
There was a problem hiding this comment.
I vote that we instead just say:
cdinto the js dir.cdintowasm/submodules/rive-runtimeand run..
Instead of hardcoding the commands like this.
Or alternatively do:
pushd wasm/submodules/rive-runtime/
....
popd
...
pushd js
HayesGordon
reviewed
Nov 19, 2024
| brew install python | ||
|
|
||
| # Add a symlink | ||
| ln -s /usr/local/bin/python3.9 /usr/local/bin/python |
There was a problem hiding this comment.
I don't think creating a symlink is the right call, it may interfere with the symlinks brew already makes.
I used to have an alias setup to point python to python3. But I removed that and the scripts are working for me.
@lancesnider can you check to see if it's working for you by simply having python3 installed without creating the symlink or any other preference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor changes to the CONTRIBUTING.md docs:
rive-runtimebranch name frommastertomain