Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need debug and release Skia builds #188

Open
mikerreed opened this issue Mar 3, 2022 · 1 comment
Open

Need debug and release Skia builds #188

mikerreed opened this issue Mar 3, 2022 · 1 comment

Comments

@mikerreed
Copy link
Contributor

When we build skia(lib) as a dependency (which we do all over the place) we need to support passing in 'debug' or 'release', so the skialib will 'match' the setting in our tool/app.

This is important not just for performance (release is faster), but occasionally for correctness too ... A header might declare an object differently in those two modes, and if we're not consistent, we could break the ABI at runtime.

@luigi-rosso
Copy link
Collaborator

I'm totally guilty of not respecting this. I think I have all the configs set to build Skia in Release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants