Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable User to Add Schedule Name Immediately After Creating #15

Open
1 of 3 tasks
fahdikrie opened this issue Oct 5, 2021 · 1 comment
Open
1 of 3 tasks

Enable User to Add Schedule Name Immediately After Creating #15

fahdikrie opened this issue Oct 5, 2021 · 1 comment
Labels
enhancement New feature or request hacktoberfest

Comments

@fahdikrie
Copy link
Member

fahdikrie commented Oct 5, 2021

This issue is a:

  • bug report
  • feature request
  • styling change request

Current behavior:

As of now, every schedules are automatically named as 'Untitled' after it is saved. It can only be renamed after you open the schedule detail page.

Screen Shot 2021-10-06 at 02 30 24

Requested behavior:

The design team from Ristek proposed that it would be better if user get the chance to give each schedules' name before (and not after) saving it.

Screen Shot 2021-10-06 at 02 27 45

Related Issue:

Also see this issue on SusunJadwal's backend repository:
ristekoss/susunjadwal-backend#9

Why this behavior is better:

It is suggested by Ristek's design team that this would lead to a better and more coherent user flow.

@fahdikrie fahdikrie added enhancement New feature or request hacktoberfest labels Oct 5, 2021
@fahdikrie fahdikrie changed the title Give Schedule Name Immediately After Creating Enable User to Add Schedule Name Immediately After Creating Oct 5, 2021
@leleonardo81
Copy link
Contributor

I might have a solution proposed for this. The solution will be only on frontend side of app, so there is no need to have a changes in backend.

The frontend will create a modal form for schedule name as the design proposed.
but since we've already had API for renaming the schedule (separate from the create schedule API).
on frontend we can just send renaming request, after successfully creating the schedule. We'll have schedule id after create and be able to rename the schedule. This can be achieved by chaining renaming requests asynchronously only after creating schedule is finished.

Therefore we don't need to have any addition or edit for the API service in backend.
But, for sure having Create Schedule API able to recieve the schedule name in request body might be the convenient way also, since it will request once per schedule create rather than 2 API request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest
Projects
None yet
Development

No branches or pull requests

2 participants