Bug: User JWT has no expiry

[Veivel]

This issue is a:

• bug report

Current behavior:

If you decode the Bearer token used to make requests to the backend, you will get:

(data cropped for obvious reasons)

A quick search through the repository also shows no duration or exp values.

susunjadwal-backend/app/jwt_utils.py

Lines 5 to 13 in 0029867

	def encode_token(data):
	return jwt.encode(data, app.config["SECRET_KEY"], algorithm='HS256').decode()
	def decode_token(token):
	try:
	data = jwt.decode(token, app.config["SECRET_KEY"], algorithm='HS256')
	except:
	return None

susunjadwal-backend/app/utils.py

Lines 11 to 16 in 0029867

	def generate_token(user_id, major_id):
	token = encode_token({
	'user_id': str(user_id),
	'major_id': str(major_id),
	})
	return token

Requested behavior:

Generate every token with an expiry date.

Why this behavior is better:

Don't think this needs any explanation.
https://gist.github.com/soulmachine/b368ce7292ddd7f91c15accccc02b8df

Note

If anyone wants to fix this, feel free to do so :)