Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questions on riscv-ast-raw.txt #562

Open
wxrdnx opened this issue Sep 25, 2024 · 3 comments
Open

Questions on riscv-ast-raw.txt #562

wxrdnx opened this issue Sep 25, 2024 · 3 comments

Comments

@wxrdnx
Copy link

wxrdnx commented Sep 25, 2024

What is the purpose of generated_definitions/ast/riscv-ast-raw.txt and how is it generated?

@Alasdair
Copy link
Collaborator

It's a dump of the Sail internal AST. Not sure why it's there - could be for some RMEM deep embedding experiment. It's from 5 years ago when we were first building the model, and weren't being particularly careful with what we checked in.

As to how it was generated - not sure we still have the code set up to do it, but the Sail internal AST is specified as an Ott grammar, and Ott can (or could) dump the contents of that in a format that is basically a big OCaml literal.

We should probably remove it.

@Timmmm
Copy link
Collaborator

Timmmm commented Sep 29, 2024

Should we remove the entire prover_snapshots directory? Or move it to another repo at least?

@bacam
Copy link
Collaborator

bacam commented Oct 1, 2024

Yes, those snapshots are seriously out-of-date. Ideally we'd have the CI generate some and when it fails only spam the people who might fix it, but currently they probably won't build without updates to the handwritten bits anyway. (Which I might try and sort out quite soon.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants