Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

standard processor-specific block structure does not match SMBIOS spec #9

Open
kimonberlin opened this issue Jan 26, 2022 · 14 comments

Comments

@kimonberlin
Copy link

The "standard processor-specific block structure" described in section 2.2 does not match the "processor-specific block" defined in section 7.45.1 of SMBIOS 3.5.0.
The fields should be "block length", "processor type", and "processor-specific data".

@changab
Copy link
Collaborator

changab commented Jan 28, 2022

Thanks for catching this, I will correct it in riscv-smbios spec.

@jiegec
Copy link

jiegec commented Dec 11, 2023

Ping @changab

@changab
Copy link
Collaborator

changab commented Dec 11, 2023

Wow, this ticket was opened in 2022 Jan. I am no longer working on RISC-V as I joined AMD. Could you please help to send the PR?

@jiegec
Copy link

jiegec commented Dec 11, 2023

There seemed to be a newer (and incompatible) definition at https://github.com/riscv-non-isa/riscv-brs/blob/main/smbios.adoc, which one should be used?

@changab
Copy link
Collaborator

changab commented Dec 11, 2023

Hi @jiegec, I am not quite clear. Which definition do you refer? Could you please point me to that definition?

@jiegec
Copy link

jiegec commented Dec 11, 2023

Hi @jiegec, I am not quite clear. Which definition do you refer? Could you please point me to that definition?

The SMBIOS Type 44 Processor-Specific Data definition seemed different.

@changab
Copy link
Collaborator

changab commented Dec 11, 2023

Are you saying the definition of SMBIOS type 44 is different than RISC-V SMBIOS Type44 processor-specific data?
The one defined in SMBIOS spec is the SMBIOS type 44 structure (the header). The one defined here is the processor-specific data which should be located at the offset 02h in table 130 in SMBIOS section 7.45.1.

@jiegec
Copy link

jiegec commented Dec 11, 2023

RISC-V Processor-specific Block Structure in this repo has revision v0.10, but in riscv-brs, the revision is v1.00.

@changab
Copy link
Collaborator

changab commented Dec 11, 2023

Ah I see. I think https://github.com/riscv-non-isa/riscv-brs/blob/main/smbios.adoc is newer. I think they created riscv-brs later.

@jiegec
Copy link

jiegec commented Dec 11, 2023

However, the SMBIOS spec still refers to this repo, which is the older one.

@kimonberlin
Copy link
Author

What is the new URL to put in the SMBIOS spec?

@jiegec
Copy link

jiegec commented Dec 11, 2023

I think we can archive this repo and add links to the new specification.

@changab
Copy link
Collaborator

changab commented Dec 12, 2023

However, the SMBIOS spec still refers to this repo, which is the older one.

ok, I will send the ECR to SMBIOS WG to update this change.

@changab
Copy link
Collaborator

changab commented Dec 12, 2023

What is the new URL to put in the SMBIOS spec?

@kimonberlin, this is the one: https://github.com/riscv-non-isa/riscv-brs/blob/main/smbios.adoc.
Please help to update this link on SMBIOS spec 7.45.2.1.

Thank you
Abner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants