-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vector Load/Store Segment Instruction mnemonics are missing #314
Comments
I think it's all of the segmented loads and stores?
7 uncovered cases for "nfields_string", 4 cases for "vlewidth_bitsnumberstr", so about (10 * 7 * 4 + 7) ~287 missing mnemonics? |
@AFOliveira, any ideas? |
I was looking to understand issues with the V extension (riscv/riscv-opcodes/issues/322) and your issue helped me to understand this, so thank you @BrianAnakPintar! Proposed solutions I see for this:
I am more inclined towards the 2, since I think it better serves the purpose of having a DB of instructions, but probably the argument to defend 1 is to avoid almost duplicated instructions since they only slightly differ from each other. I think doing 2 would be relatively easy (probably doable until the end of the week). What do you guys think would be the best approach? |
Additionally, I just realized that .json in riscv-opcode is relatively new and does not exist in the version of riscv-opcodes we have as a submodule here in the UDB, that might be another reason as to why this slipped :). @dhower-qc Do you think it's worth it to PR the update of riscv-opcodes, it's changed a lot and I guess @BrianAnakPintar also needs it. |
I was recently testing the results by converting the instructions from UDB to riscv-opcodes' format (#300) and one issue I noticed is that UDB seem to be missing several instructions. I am unsure whether there is a way to obtain these from existing instructions in the UDB or if we simply don't have a way to obtain them:
On the left is from UDB and on the right is riscv-opcodes'
There's a handful of these missing instructions, here's a few of them:
The text was updated successfully, but these errors were encountered: