Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot pass ESLint validation #241

Open
tylerlong opened this issue Jun 11, 2017 · 1 comment
Open

Cannot pass ESLint validation #241

tylerlong opened this issue Jun 11, 2017 · 1 comment

Comments

@tylerlong
Copy link
Contributor

image

Ideally, ESLint validation should be added to CI.

@u9520107
Copy link
Contributor

@tylerlong We actually are using codacy to check these at the moment, but we have not yet started to enforce these rules, nor have we really discussed the rule sets at this stage. Ideally, any new code we check in pass the codacy check, and we should also start to make sure old code start to conform to these rules. Quite frankly I don't think we'll just do this in one step and make every file pass this test at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants