-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot pass ESLint validation #241
Labels
Comments
@tylerlong We actually are using codacy to check these at the moment, but we have not yet started to enforce these rules, nor have we really discussed the rule sets at this stage. Ideally, any new code we check in pass the codacy check, and we should also start to make sure old code start to conform to these rules. Quite frankly I don't think we'll just do this in one step and make every file pass this test at the moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Ideally, ESLint validation should be added to CI.
The text was updated successfully, but these errors were encountered: