Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New RStudio Version (2022.07.0) Breaks --ds-tab-gradient-dark on MacOS #24

Open
grcatlin opened this issue Jul 19, 2022 · 2 comments
Open

Comments

@grcatlin
Copy link

grcatlin commented Jul 19, 2022

Hi Riley,

Using RStudio 2022.02.0, --ds-tab-gradient-dark works as expected:

image

However, on the latest build (2022.07.0, and possibly earlier builds) this behavior changes:

image

I guess they must've swapped something only in the Mac version of RStudio because the Windows version on the latest build works fine - I haven't tried Linux.

Thanks for the cool work!

@grcatlin grcatlin changed the title New RStudio Version (2022.07.0) Breaks --ds-tab-gradient-light on MacOS New RStudio Version (2022.07.0) Breaks --ds-tab-gradient-dark on MacOS Jul 20, 2022
@grcatlin
Copy link
Author

I mistook it for --ds-tab-gradient-light before, it's actually --ds-tab-gradient-dark and is fixed easily by adding .GND-IWGDKS to the following section in the css file:

/* Source editor tab overflow gradient */
.rstudio-themes-flat
  .rstudio-themes-dark-grey
  :-webkit-any(.GGBOEFPDDS, .GD15MCFCCS, .GCHYANPCES, .GEL-OVUBOR, .GND-IWGDKS) {
  background: var(--ds-tab-gradient-dark) !important;
}

@rileytwo
Copy link
Owner

@grcatlin I'll get this fixed, thanks for the help. Most of RStudio's css is generated by GWT, and the styled gradients often break with updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants