Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error with Grape 2.1.2 #27

Open
lavaturtle opened this issue Jul 8, 2024 · 0 comments · May be fixed by #28
Open

Error with Grape 2.1.2 #27

lavaturtle opened this issue Jul 8, 2024 · 0 comments · May be fixed by #28

Comments

@lavaturtle
Copy link

I recently upgraded from Grape 2.0.0 to Grape 2.1.2, and now I'm seeing an error in grape-middleware-logger when I make any request:

E, [2024-07-08T09:19:46.339918 #9444] ERROR -- : uninitialized constant Grape::Env::RACK_REQUEST_FORM_HASH
	/home/grey/.rvm/gems/ruby-3.3.3@tokyo/gems/grape-middleware-logger-1.12.0/lib/grape/middleware/logger.rb:96:in `parameters'
	/home/grey/.rvm/gems/ruby-3.3.3@tokyo/gems/grape-middleware-logger-1.12.0/lib/grape/middleware/logger.rb:40:in `before'
	/home/grey/.rvm/gems/ruby-3.3.3@tokyo/gems/grape-middleware-logger-1.12.0/lib/grape/middleware/logger.rb:51:in `call!'
	/home/grey/.rvm/gems/ruby-3.3.3@tokyo/gems/grape-2.1.2/lib/grape/middleware/base.rb:27:in `call'
       ...

I assume the Grape::Env::RACK_REQUEST_FORM_HASH constant has been removed in the latest version of Grape. Would it be possible to update grape-middleware-logger to work with Grape 2.1.x? Alternatively, the gemspec should probably specify that the version of grape should be 2.0.0 or less.

@ahmeij ahmeij linked a pull request Jul 31, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant