Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove control_cost() method from Walker2d and Hopper when gymnasium v5 environments are released #267

Open
rickstaa opened this issue Jul 26, 2023 · 0 comments
Labels
enhancement New feature or request upstream Problems caused by upstream issues.

Comments

@rickstaa
Copy link
Owner

rickstaa commented Jul 26, 2023

Is your feature request related to a problem? Please describe.

Currently, in the Walker2d and Hopper we have to recalculate the ctrl_cost since it is not passed to the info dictionary. This has already been solved in Farama-Foundation/Gymnasium#572 but has yet to be released. When the v5 environment is released the following code can be removed:

ctrl_cost = super().control_cost(action)

ctrl_cost = super().control_cost(action)

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

Additional context

We should double-check the keys found in the info dictionary when the v5 environments are released.

@rickstaa rickstaa added enhancement New feature or request upstream Problems caused by upstream issues. labels Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request upstream Problems caused by upstream issues.
Projects
None yet
Development

No branches or pull requests

1 participant