Upgraded to AGP 3.0 #79
Conversation
* Upgraded some dependencies to their latest version. * Bumped compileSdk and targetSdk to android O (26).
Conflicts: app/build.gradle build.gradle gradle/wrapper/gradle-wrapper.properties
|
Can one of the admins verify this patch? |
|
Hello, Can anyone verify this patch? Thanks! |
There was a problem hiding this comment.
Hello, thanks for the pull request! It's always nice to get help with keeping the project up to date. :)
As you rightly point out, the checks will fail on this branch currently. I am not keen to merge it knowing it will fail.
I have done a little research, and seems to be a known lint issue. https://groups.google.com/forum/#!topic/lint-dev/OxesC-aRg6c
I have tried updating the plugin again to 3.0.1 (probably this came out after you opened the pull request), and the lint check now passes when run independently, however the complete 'check' process now fails for me with an unhelpful 'unknown' cause. This may be a problem with my setup..
I will be happy to merge this once we have resolved the failures.
| compileSdkVersion 25 | ||
| buildToolsVersion '25.0.3' | ||
| compileSdkVersion 26 | ||
| buildToolsVersion '26.0.2' |
There was a problem hiding this comment.
It seems that as of Gradle plugin 3.0.0, we no longer need to specify the build tools version, so we can remove this.
"With this update, you no longer need to specify a version for the build tools—the plugin uses the minimum required version by default. So, you can now remove the android.buildToolsVersion property."
https://developer.android.com/studio/releases/gradle-plugin.html#3-0-0
Note:
./gradlew checkwill fail unless you put a release keystore atapp/keystore/release.keystore. ApparentlyvalidateSigningProdReleasetask is now part ofcheck