Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that a given RSS feed contains at least one <enclosure> tag before allowing it to be added #253

Open
WVJaguar opened this issue Nov 14, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@WVJaguar
Copy link

I used the rss feed shown on the web page
https://timharford.com/2006/09/rss-feed-of-undercover-economist/:

https://timharford.com/2006/09/rss-feed-of-undercover-economist/
(At the top of this page is:
"This XML file does not appear to have any style information associated with it. The document tree is shown below.")

The subscription was accepted and appears in the list.

@WVJaguar WVJaguar added the bug Something isn't working label Nov 14, 2022
@ribbons
Copy link
Owner

ribbons commented Nov 15, 2022

Apologies if I'm missing something but the RSS feed linked on that page ( https://www.ft.com/undercover-economist?format=rss ) appears to be linking to written articles instead of being a podcast feed. As podcast feeds are just a kind of RSS feed which reference audio files it isn't completely surprising that Radio Downloader accepts it happily.

Perhaps Radio Downloader should check to see if a feed contains any audio enclosures before it accepts it as a valid podcast, what do you think?

@WVJaguar
Copy link
Author

WVJaguar commented Nov 17, 2022 via email

@ribbons
Copy link
Owner

ribbons commented Nov 17, 2022

A quick way to check would be to search for <enclosure in the feed XML as a podcast feed would always contain those tags. You can then look to see the contents to make sure they are audio files instead of video (although I'm guessing that video-only feeds aren't that common).

I'll re-purpose this issue to cover adding a check to see if a feed contains enclosure tags before allowing it to be added.

@ribbons ribbons added enhancement New feature or request and removed bug Something isn't working labels Nov 17, 2022
@ribbons ribbons changed the title Podcast rss feed added to subscription list but episodes not downloading Check that a given RSS feed contains at least one <enclosure> tag before allowing it to be added Nov 17, 2022
@WVJaguar
Copy link
Author

WVJaguar commented Nov 18, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants