Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

actions/download-artifact for GHE environment #468

Closed
andreineculau opened this issue Nov 5, 2024 · 7 comments
Closed

actions/download-artifact for GHE environment #468

andreineculau opened this issue Nov 5, 2024 · 7 comments

Comments

@andreineculau
Copy link

using v3 fails actionlint with

the runner of "actions/upload-artifact@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue [action]

but actions/upload-artifact@v4 cannot be used on GHES

Warning: Artifact upload failed with error: GHESNotSupportedError: @actions/artifact v2.0.0+, upload-artifact@v4+ and download-artifact@v4+ are not currently supported on GHES..

Can we add a special condition?

@andreineculau
Copy link
Author

@nkhoidang
Copy link

Same for artifact-upload

@rhysd
Copy link
Owner

rhysd commented Nov 6, 2024

I have no idea because I don't have a GHE environment with GitHub Actions enabled. One obvious workaround for this is ignoring the erorr by regular expressions as desribed in the v1.7.4 releae note.

Before considering to add some special handling for this, I'd like to ask some questions to understand the situation better.

  • actions/upload-artifact@v3 will be unavailable soon because node16 will be dropped on Nov. 12.
    • Will actions/upload-artifact@v4 support GHE in the time frame?
    • Or will GHE continue to support node16 runner with actions/upload-artifact@v4 being unsupported in long term?
  • Is there any good document which describes what runners are supported on GHE (if supported runners are different from the github.com environment)?

I'm a bit confused because they announce that actions/upload-artifact@v4 doesn't support GHE but actions/upload-artifact@v3 is deprecated.

@rhysd rhysd changed the title actions/download-artifacts actions/download-artifact for GHE environment Nov 6, 2024
@rhysd
Copy link
Owner

rhysd commented Nov 6, 2024

rhysd added a commit that referenced this issue Nov 6, 2024
Note that this restores the workaround for #442.
@andreineculau
Copy link
Author

One obvious workaround for this is ignoring the erorr by regular expressions as desribed in the v1.7.4 releae note.

Cool. What we have done temporarily is to use the commit hash pointing to the current v3 (at the expense of maybe failing to keep up to the date with v3 patches). I didn't know about the v3-node20 versions 🙌

I'm a bit confused because they announce that actions/upload-artifact@v4 doesn't support GHE but actions/upload-artifact#635.

There's some info related to roadmap here actions/upload-artifact#537 - tl;dr v3 will be deprecated but will still run on GHES moving forward, with the expectation that v4 will be supported Q1 2025

Is there any good document which describes what runners are supported on GHE (if supported runners are different from the github.com environment)?

Not sure what you mean. On GHES you only have self-hosted runners AFAIK, so anything goes.

@rhysd
Copy link
Owner

rhysd commented Nov 7, 2024

at the expense of maybe failing to keep up to the date with v3 patches

Yeah, I don't know how it is maintained. However v3 is deprecated and I don't think new features will be added.

There's some info related to roadmap here actions/upload-artifact#537 - tl;dr v3 will be deprecated but will still run on GHES moving forward, with the expectation that v4 will be supported Q1 2025

Thank you for the information. Then I believe v3/node20 branch will be maintained until v4 supports GHES. v3 cannot be upgraded to node20 runner because it breaks the compatibility. And v4 is not supporting GHES yet. Maintaining v3/node20 is the only way to support GHES.

Not sure what you mean. On GHES you only have self-hosted runners AFAIK, so anything goes.

I didn't know that GHES only supports self-hosted runners. As I said above, I don't have GHES environment hence I don't know the specs at all. Thanks for explaining that 👍

@rhysd
Copy link
Owner

rhysd commented Nov 10, 2024

I'm closing this because actions/download-artifact@v3-node20 is the current solution.

@rhysd rhysd closed this as completed Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants