From 988099305bc48b94a1add5125734aa53696e8048 Mon Sep 17 00:00:00 2001 From: Colin Cogle Date: Mon, 23 Sep 2024 09:18:17 -0400 Subject: [PATCH] Fix bug rejecting packets with 100% humidity. An error in all previous versions of aprs-weather-submit prevented the creation of packets with 100% relative humidity. This off-by-one error has been corrected, and I am making this a whole new version. Thank you to Jeffrey McPike, N9CQS, for the bug report submitted via email. --- CHANGELOG.md | 8 ++++++-- NEWS.md | 14 +++++++++++--- configure.ac | 2 +- debian/changelog | 7 ++++--- debian/docs | 1 - debian/files | 6 +++--- src/main.c | 2 +- src/main.h | 2 +- 8 files changed, 27 insertions(+), 15 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 7569f95..8fdbf37 100755 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,9 @@ -## Not yet released -* Preliminary support for compiling and running against the Win32 API. +# Change Log for `aprs-weather-submit` + +## Version 1.7.2 + +* Fixed a bug that would prevent users from creating APRS packets with 100% relative humidity. Thanks to Jeff (N9CQS) for the bug report! +* Minor packaging improvements for Debian repositories. ## Version 1.7.1 diff --git a/NEWS.md b/NEWS.md index 824d977..80d22c9 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,13 +1,21 @@ # aprs-weather-submit news -This file details all of the user-facing changes that are in version 1.7 of aprs-weather-submit. For more details, please consult the CHANGELOG file or this project's GitHub page. +This file details all of the user-facing changes that are in versions 1.7 of aprs-weather-submit. For more details, please consult the CHANGELOG file or this project's GitHub page. -## CUSTOM ICONS +## Custom Icons The new `--icon` parameter lets you specify a character from the two symbol tables. If not specified, you will get the classic weather icon. Note that APRS.fi does not support parsing weather data from packets that have custom icons. If this is important to you, do not use this new feature. -## ARMHF FIXES +## `armhf` Fixes Version 1.7 did not compile on the armhf platforms. Version 1.7.1 is fixed. + +## It's not the heat, it's the humidity! + +Before version 1.7.2, one could not create an APRS packet with 100% relative humidity due to a bug in the code that only allowed values from 1% to 99%. This was corrected in version 1.7.2 thanks to a report from Jeff, N9CQS. + +## Can this app be in Debian, please? + +I've also been making behind-the-scenes improvements to how this app is packaged and installed. Users of Debian-based Linux distributions can enjoy nearly-effortless installation, upgrades, and removals. diff --git a/configure.ac b/configure.ac index 49fa879..5c10761 100644 --- a/configure.ac +++ b/configure.ac @@ -17,7 +17,7 @@ dnl dnl You should have received a copy of the GNU Affero General Public License dnl along with this program. If not, see . -AC_INIT([aprs-weather-submit], [1.7.1], [https://github.com/rhymeswithmogul/aprs-weather-submit/]) +AC_INIT([aprs-weather-submit], [1.7.2], [https://github.com/rhymeswithmogul/aprs-weather-submit/]) AM_INIT_AUTOMAKE([foreign subdir-objects -Wall -Werror]) AC_PREREQ AC_PROG_INSTALL diff --git a/debian/changelog b/debian/changelog index 2766264..7ed1c69 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,5 +1,6 @@ -aprs-weather-submit (1.7.1-2) UNRELEASED; urgency=medium +aprs-weather-submit (1.7.2-1) UNRELEASED; urgency=medium - * Fixed a compile-time error on armhf platforms. + * Fixed a bug that prevented creating APRS packets with 100% relative + humidity. (Thanks to Jeff, N9CQS, for the report.) - -- Colin Cogle Thu, 30 Nov 2023 01:32:00 -0500 + -- Colin Cogle Mon, 23 Sep 2024 09:09:09 -0400 diff --git a/debian/docs b/debian/docs index 8e1dac1..47c017b 100644 --- a/debian/docs +++ b/debian/docs @@ -1,6 +1,5 @@ AUTHORS CHANGELOG.md CODE_OF_CONDUCT.md -LICENSE NEWS.md README.md diff --git a/debian/files b/debian/files index 6ffdaab..89e2e3d 100644 --- a/debian/files +++ b/debian/files @@ -1,3 +1,3 @@ -aprs-weather-submit-dbgsym_1.7-1.1_amd64.ddeb debug optional automatic=yes -aprs-weather-submit_1.7.1-1_amd64.buildinfo hamradio optional -aprs-weather-submit_1.7.1-1_amd64.deb hamradio optional +aprs-weather-submit-dbgsym_1.7-2.1_amd64.ddeb debug optional automatic=yes +aprs-weather-submit_1.7.2-1_amd64.buildinfo hamradio optional +aprs-weather-submit_1.7.2-1_amd64.deb hamradio optional diff --git a/src/main.c b/src/main.c index 9c2c65a..49e6e4d 100755 --- a/src/main.c +++ b/src/main.c @@ -458,7 +458,7 @@ main (const int argc, const char** argv) /* Humidity, in the range from 1 to 100% (-h | --humidity) */ case 'h': x = atoi(optarg); - if (x < 0 || x > 99) + if (x < 0 || x > 100) { fprintf(stderr, "%s: option `-%c' must be between 0%% and 100%%.\n", argv[0], optopt); return EXIT_FAILURE; diff --git a/src/main.h b/src/main.h index b457074..05d941d 100755 --- a/src/main.h +++ b/src/main.h @@ -28,7 +28,7 @@ with this program. If not, see . #endif #ifndef VERSION -#define VERSION "1.7.2-git" +#define VERSION "1.7.2" #endif /* We don't support networking on DOS at this time.