Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test #134

Merged
merged 16 commits into from
Sep 21, 2021
Merged

Fix test #134

merged 16 commits into from
Sep 21, 2021

Conversation

Calvin-Huang
Copy link
Contributor

@Calvin-Huang Calvin-Huang commented Jun 28, 2020

  • Upgrade travis's dependent ES service to 7.8.0.
  • Use py 3.5 (3.7 is okay on my local, but I don't wanna make a big break change).
  • Ensure the pytest works in travis.
  • Fix the goldbreg.py test.

Related PRs: #132 , #133

@codecov-commenter
Copy link

Codecov Report

Merging #134 into master will increase coverage by 0.07%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #134      +/-   ##
==========================================
+ Coverage   70.50%   70.58%   +0.07%     
==========================================
  Files           5        5              
  Lines         373      374       +1     
==========================================
+ Hits          263      264       +1     
  Misses        110      110              
Impacted Files Coverage Δ
image_match/signature_database_base.py 90.81% <ø> (ø)
image_match/goldberg.py 83.75% <66.66%> (+0.10%) ⬆️
image_match/elasticsearch_driver.py 97.50% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33682eb...e8cf771. Read the comment docs.

@eyalsus
Copy link

eyalsus commented Jul 16, 2020

thank you for the code updates, is it going to be pushed to master?

@Calvin-Huang
Copy link
Contributor Author

@eyalsus Seems like this repo has been suspended for a while. You can use our fork https://github.com/CapsLock-Studio/image-match until the MR has been accepted.

@rhsimplex rhsimplex merged commit 4262f44 into rhsimplex:master Sep 21, 2021
@rhsimplex
Copy link
Owner

Thank you @Calvin-Huang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants