Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let the app load its intents/slots/… from a file #11

Open
koenvervloesem opened this issue Jun 13, 2020 · 3 comments
Open

Let the app load its intents/slots/… from a file #11

koenvervloesem opened this issue Jun 13, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@koenvervloesem
Copy link
Member

Let the app load its intents/slots/… from a file and re-train Rhasspy on installation/startup of the app.

See rhasspy/rhasspy-hermes#12

@koenvervloesem koenvervloesem added the enhancement New feature or request label Jun 13, 2020
@maxbachmann
Copy link
Member

maxbachmann commented Aug 26, 2020

One thing to keep in mind with this is that it should only retrain when there was a change (either to the files or some other settings like e.g. the language) and not on each restart, since training can take very long when a lot of sentences need to be generated.

@koenvervloesem
Copy link
Member Author

Good point. So we should compare the locally defined intents and slots with the ones known/trained by Rhasspy then, and only trigger Rhasspy to re-train when they differ?

@maxbachmann
Copy link
Member

I think it would be hard to compare them to the trained ones, since this would require generating them aswell.
Reasons to retrain from the top of my head:

One more thing is that when skills retrain by sending their intents + slots we do want them to do this at the same time. It would be a complete mess when:

  • skill A sends the intents
    -> rhasspy starts to retrain
  • skill B sends the intents
    -> rhasspy has to retrain again

I am currently not sure how to implement this in an optimal way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants