Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clean target to Makefile #19

Open
oxr463 opened this issue Jun 26, 2022 · 3 comments
Open

Add clean target to Makefile #19

oxr463 opened this issue Jun 26, 2022 · 3 comments

Comments

@oxr463
Copy link

oxr463 commented Jun 26, 2022

These invocations of rm -rf $@ for each target in the Makefile should be put in a separate clean target. That way it doesn't remove everything each time the user re-runs make.

This would be especially helpful for all of the large files that are downloaded during the build process.

@oxr463
Copy link
Author

oxr463 commented Jun 26, 2022

A good example would be this: #20

@rgl
Copy link
Owner

rgl commented Jun 27, 2022

Not sure what you mean. What do you think it's being deleted, why and when?

@oxr463
Copy link
Author

oxr463 commented Jul 2, 2022

One example is this line: https://github.com/rgl/windows-vagrant/blob/master/Makefile#L205

Deleting that directory also deletes the ISO that gets downloaded, which is over 1GB.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants