-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Submit border patrol data to Tidy Tuesday #770
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much! This is really close, just a few tweaks here and there. It's so nice to be able to take the time to perfect this, rather than slapping something together at the last minute like I've had to do a few times recently 🙃
Definitely let me know if there's anything that was particularly confusing in the instructions, particularly things that you thought you might have done wrong but it turned out you were right. I want to instill as little fear of failure/impostor syndrome as I can!
I don't know your comfort level/experience with PRs, so in case you aren't sure what's next:
- Click "Commit suggestion" on anything that you agree with in my review, to apply that change to your submission.
- On your machine, Pull the changes from github to your local copy. You can click "Pull" in the RStudio "Git" tab, run
usethis::pr_pull()
, or use the command line togit pull
the updates. Or technically you can probably use the web UI for the things that are left to change, but I'm always more comfortable working locally. - Make the additional edits described. Let me know if you need help with anything!
- "Push" the changes up to github ("Git" tab,
usethis::pr_push()
, orgit push
). - (If you can; you might not have permission to do this) Click the circle-arrow next to my name under "Reviewers". That isn't really necessary here (I get alerts about every change in this repo), but it's good practice for PRs in general, to let the reviewer know "Ok, I did what you asked!"
Again, thank you SO MUCH for this! It's super helpful!
@jonthegeek Thanks for the review and suggestions. I do not have much experience with GitHub (even though I have 2 accounts: 1 personal and 1 for work). My personal account is what I use for my Tidy Tuesday work, but I also connected my work account to RStudio to use CoPilot. I think this is how I got messed up. I don't think my stuff ended up on the fork I created. Maybe that's why I can't see "Commit suggestion". Here's what I see for the first suggestion: |
Doh! I need to make my profile pictures different. I was logged in to GitHub with my work account (which is why I couldn't see the "Commit suggestion" button. I made the changes manually and committed them. Hopefully that works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The post still isn't accessible, unfortunately. Let's figure out something people can see! Make sure you aren't logged in as acorns! 😁
… I created the plot
I moved the article to GitHub pages and updated the alt text. Now that I have GitHub pages set up, I might have to start working on cleaning the website. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Now I need to assign it to a week, and make sure nothing strange happens in that process...
/assign border-patrol 2024-11-26 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple small tweaks, which I'll accept and merge. Thanks!
Thank you for your submission! Please leave this text as-is when you submit, and then check the checklist.
Usability:
Preparation:
cleaning.R
has code to download and clean the dataset, resulting in descriptively-named data.frames.saving.R
to createcsv
s andmd
data dictionaries for each of my data.frames.{dataset}.md
files.intro.md
file to introduce my dataset.png
file.meta.yaml
, including descriptive alt text for each image.meta.yaml
about how to credit me, and deleted any parts of that block that I do not want you to use.