Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude NY HER "coming soon" cards #195

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

veekas
Copy link
Member

@veekas veekas commented Nov 22, 2024

Description

Describe the purpose and mechanics of this change. If applicable, include links/references to issues, docs, tickets, etc.

Test Plan

Describe what you did to test this PR. Reviewers can use this to identify additional cases that might have been missed. Be sure another developer could follow the same steps.

Changes should be tested at all three screen breakpoints (small, medium, large), and shouldn't interfere with accessibility (especially for screen reader and keyboard users).

Copy link

vercel bot commented Nov 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
embed-rewiringamerica-org ✅ Ready (Inspect) Visit Preview Nov 22, 2024 8:59pm

@veekas veekas enabled auto-merge (squash) November 27, 2024 13:50
@veekas
Copy link
Member Author

veekas commented Nov 27, 2024

trying to debug the color contrast issue, not sure why it's happening to this PR, e.g.

    {
        "any": [
            {
                "id": "color-contrast",
                "data": {
                    "fgColor": "#adaa9d",
                    "bgColor": "#fffcef",
                    "contrastRatio": 2.26,
                    "fontSize": "12.0pt (16px)",
                    "fontWeight": "normal",
                    "messageKey": null,
                    "expectedContrastRatio": "4.5:1"
                },
                "relatedNodes": [
                    {
                        "html": "<ul class=\"w-full max-h-96 overflow-y-auto cursor-pointer bg-white shadow-elevation rounded outline-0 py-2\" aria-labelledby=\"project-selector\" aria-orientation=\"vertical\" id=\"headlessui-listbox-options-:rg:\" role=\"listbox\" tabindex=\"0\" data-headlessui-state=\"\" style=\"position: absolute; left: 0px; top: 0px; transform: translate(0px, 1px); will-change: transform;\">",
                        "target": [
                            "#headlessui-listbox-options-\\:rg\\:"
                        ]
                    }
                ],
                "impact": "serious",
                "message": "Element has insufficient color contrast of 2.26 (foreground color: #adaa9d, background color: #fffcef, font size: 12.0pt (16px), font weight: normal). Expected contrast ratio of 4.5:1"
            }
        ],
        "all": [],
        "none": [],
        "impact": "serious",
        "html": "<span class=\"grow\">Battery storage</span>",
        "target": [
            "#headlessui-listbox-option-\\:rh\\: > .grow"
        ],
        "failureSummary": "Fix any of the following:\n  Element has insufficient color contrast of 2.26 (foreground color: #adaa9d, background color: #fffcef, font size: 12.0pt (16px), font weight: normal). Expected contrast ratio of 4.5:1"
    }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants