-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "other" option to utility selector #149
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
I should note a couple more things:
|
Waiting on this until we expose utilities for all states including non-covered ones. |
@@ -130,6 +130,7 @@ export const templates = { | |||
sc373af4c1a974b57: `Cocina`, | |||
sc5b20cb72269bc4f: `Los propietarios y inquilinos califican para diferentes incentivos.`, | |||
sc997cfdf24ba9b58: `Aún no tenemos datos sobre las empresas de servicios eléctricos en su área.`, | |||
sc9e494c8346b7cb5: `Otra`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Otra" makes sense to me!
## Description Because we can't be sure that the API's set of utilities is 100% comprehensive, or that its location-to-utilities mapping is 100% correct, we should have an escape hatch, so users don't have to give an answer they know is incorrect. The "other" value is not submitted to the API because it's not a valid utility ID and the API would thus error. I'm pretty confident that's sensible behavior for the API, so I'd rather not change it. We'll be able to tell when someone chose "other" in API logs, when (a) the utility param is absent in the /calculator request, while (b) the zip is in a launched state. Since it's hard to know if a zip is in a launched state when you're just looking at API logs, we may want to explicitly record zips submitted with an "other" utility somewhere; if so, we can do that as a followup. I'm not sure about this Spanish translation. It's "otra" (feminine) because it's referring to the feminine noun "empresa" (company), which is part of the translation of "electric utility". Anyone who knows Spanish better than I do (i.e. most people), feel free to correct me. https://app.asana.com/0/1206661332626418/1206700057950880 ## Test Plan On a fresh page load, make sure the utility dropdown is not clickable. Enter a zip in a launched state (02861); make sure utilities load, the first one is selected, and the "Other" entry is present. Submit the form with a real utility selected and make sure its incentives come up. Choose "Other", submit the form, and make sure no utility incentives come up, but state and federal ones do. Enter a zip in a non-launched state (76104); make sure utilities load, and "Other" is the only option. Enter an invalid zip (00000) and make sure the utility dropdown is not clickable and you see the error message below the field.
I've done a new thing here, updating the logic of what to display as helper text. Previously we'd display "Enter your zip code to select a utility" even after the user had done both of those things. This replaces it with:
The blank help text is one of several non-ideal options, which are:
This code implements the leave-space option. Here's what it looks like: |
I think "Other" can still be considered to be on the happy path, it may give the user a moment of pause but hopefully they just move onto the next field. I think the helper text could be blank in that case? But I'm also OK with where we're headed as-is, it seems to be a material improvement vs losing people when they don't "see themselves" in the options. One thought re: layout for Emiola when he's back, perhaps our forms need to leave space for helper text on all fields by default always? That might be too much whitespace, but it might be preferable to redoing layout and preferable to uneven looking forms. Probably one for the longer term Design System conversation though. Also noting we cannot be alone in trying to solve these problems (though the embed constraint does mean we can't make the form multi-step easily, which is what we'd probably do in an app context). |
Re: "We don't have utility data for your area yet." - I'm personally not sure if we ever need to say this. It might be better to push that to a footer status or some other area of the page, if we draw attention to it at all. I would focus on getting the user through the form with the most accurate representation of their current status, and then we can focus on improving data coverage for them. One other thought is that we might want to feature flag or A/B test this, if we're worried it would make conversion worse. But I have a strong hypothesis it will make conversion better, I'm happy to go with gut on this to keep us moving. (Famous last words ha) |
The "we don't have utility data" message will now only show up for territories, and we can fix that pretty easily (AFAIK each territory only has one utility; we can hardcode it in the API). The idea of removing the help text in the "Other" case makes me think of another alternative:
I feel like it goes a little bit against the spirit of placeholder text, but it's something to think about. Anyway I'm going to go ahead with what I've implemented here for now (blank text allowed; uneven spacing in blank case. Keeping the "continue" copy in the Other case because that's what Emiola spec'd). |
Description
Because we can't be sure that the API's set of utilities is 100%
comprehensive, or that its location-to-utilities mapping is 100%
correct, we should have an escape hatch, so users don't have to give
an answer they know is incorrect.
The "other" value is not submitted to the API because it's not a valid
utility ID and the API would thus error. I'm pretty confident that's
sensible behavior for the API, so I'd rather not change it. We'll be
able to tell when someone chose "other" in API logs, because the
utility param is absent in the /calculator request.
I'm not sure about this Spanish translation. It's "otra" (feminine)
because it's referring to the feminine noun "empresa" (company), which
is part of the translation of "electric utility". Anyone who knows
Spanish better than I do (i.e. most people), feel free to correct me.
https://app.asana.com/0/1206661332626418/1206700057950880
Test Plan
On a fresh page load, make sure the utility dropdown is not
clickable.
Enter a zip; make sure utilities load, the first one is selected, and
the "Other" entry is present. Submit the form with a real utility
selected and make sure its incentives come up. Choose "Other", submit
the form, and make sure no utility incentives come up, but state and
federal ones do.
Enter an invalid zip (00000) and make sure the utility dropdown is not
clickable and you see the error message below the field.