Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_importer.py issues #124

Open
cgroeneveld opened this issue Nov 19, 2021 · 2 comments
Open

_importer.py issues #124

cgroeneveld opened this issue Nov 19, 2021 · 2 comments

Comments

@cgroeneveld
Copy link
Contributor

Currently, I'm trying to use parmdb2h5parm, which relies on _importer.py (in particular, it needs create_h5parm). However, there are several issues with parmdb2h5parm: it uses progressbar, which relies on a broken implementation of an abstract base class; there are some syntax errors (in particular, regex is used but never imported, caused by #10309757420c11a342ae1a8f9a43d204ac097b51).

Perhaps we can isolate and implement create_h5parm in parmdb2h5parm instead, so we do not need to rely on _importer.py?

@revoltek
Copy link
Owner

That was indeed added by users at a certain point for specific tests, it is rarely used and I agree it should be very much cleaned up...

@cgroeneveld
Copy link
Contributor Author

It might be necessary to rewrite create_h5parm as well, as I am running into several other bugs as well (unhashable type: list, for example)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants