From b90b89a94907ee5f9e2de476919b25fc60d30ced Mon Sep 17 00:00:00 2001 From: haya14busa Date: Mon, 25 May 2020 16:46:33 +0000 Subject: [PATCH 1/4] Add missing shellcheck_flags input ref: #603 --- action.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/action.yml b/action.yml index adc7232..fd23dd4 100644 --- a/action.yml +++ b/action.yml @@ -35,6 +35,9 @@ inputs: default: '*.sh' exclude: description: "Exclude patterns of target files. Same as `-not -path [exclude]` of `find` command." + shellcheck_flags: + description: "Flags of shellcheck command." + default: '--external-sources' runs: using: 'docker' image: 'Dockerfile' From 7e0d1f4da997a3af9038c933a755106857a21cf0 Mon Sep 17 00:00:00 2001 From: haya14busa Date: Mon, 25 May 2020 16:49:04 +0000 Subject: [PATCH 2/4] test shellcheck_flags --- .github/workflows/reviewdog.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/reviewdog.yml b/.github/workflows/reviewdog.yml index 882a97f..b879ddc 100644 --- a/.github/workflows/reviewdog.yml +++ b/.github/workflows/reviewdog.yml @@ -19,6 +19,7 @@ jobs: pattern: '*.sh' path: '.' exclude: './testdata/*' + shellcheck_flags: '--external-sources --severity=style' - name: shellcheck-github-pr-review uses: ./ with: From 84549756ca994da10c15022868ca64bf526ebe0f Mon Sep 17 00:00:00 2001 From: haya14busa Date: Mon, 25 May 2020 16:50:40 +0000 Subject: [PATCH 3/4] use nofilter mode for testing --- .github/workflows/reviewdog.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/reviewdog.yml b/.github/workflows/reviewdog.yml index b879ddc..adc8ae0 100644 --- a/.github/workflows/reviewdog.yml +++ b/.github/workflows/reviewdog.yml @@ -16,6 +16,7 @@ jobs: github_token: ${{ secrets.github_token }} reporter: github-check level: warning + filter_mode: nofilter pattern: '*.sh' path: '.' exclude: './testdata/*' From 3c141a846342266772150a605de5829f28c1245f Mon Sep 17 00:00:00 2001 From: haya14busa Date: Mon, 25 May 2020 16:52:54 +0000 Subject: [PATCH 4/4] use file filter mode for testing --- .github/workflows/reviewdog.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/reviewdog.yml b/.github/workflows/reviewdog.yml index adc8ae0..03bab60 100644 --- a/.github/workflows/reviewdog.yml +++ b/.github/workflows/reviewdog.yml @@ -16,7 +16,7 @@ jobs: github_token: ${{ secrets.github_token }} reporter: github-check level: warning - filter_mode: nofilter + filter_mode: file pattern: '*.sh' path: '.' exclude: './testdata/*'