Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: Improve DX by adding more named arguments to Skia-bindings #873

Open
lessp opened this issue Jun 1, 2020 · 1 comment
Open

API: Improve DX by adding more named arguments to Skia-bindings #873

lessp opened this issue Jun 1, 2020 · 1 comment
Labels
A-other Area: Other, does not fit neatly into any of the other buckets good first issue Good for newcomers

Comments

@lessp
Copy link
Member

lessp commented Jun 1, 2020

Since we also expose the Skia-bindings for a Canvas-like API I think it might be a good idea to start refactoring the API to utilise more named arguments e.g. ~x=..., ~y=....

What do you others think?
@lessp lessp added the A-other Area: Other, does not fit neatly into any of the other buckets label Jun 1, 2020
@lessp lessp changed the title API: Improve DX by adding more named arguments to reason-skia API: Improve DX by adding more named arguments to Skia-bindings Jun 1, 2020
@glennsl
Copy link
Member

glennsl commented Jun 1, 2020

Yes please! I'm working with the Skia/Canvas API right now, and needing to look up what the umpteen different float arguments of a function means is definitely a frustrating experience.

@lessp lessp added the good first issue Good for newcomers label Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-other Area: Other, does not fit neatly into any of the other buckets good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@glennsl @lessp