Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Killed invocation status variant #2331

Closed
slinkydeveloper opened this issue Nov 20, 2024 · 1 comment · Fixed by #2335
Closed

Introduce Killed invocation status variant #2331

slinkydeveloper opened this issue Nov 20, 2024 · 1 comment · Fixed by #2335
Assignees

Comments

@slinkydeveloper
Copy link
Contributor

We need to introduce Cancelling/Killing invocation status variants, specifically for Killing this means we need to slightly modify the existing behavior to wait the "End" message from the invoker after the partition processor sends "Abort", and then send back the "killed" response to sinks.

This helps with observability and we need it for #895 to make sure we don't process journal entries from the previous retry attempt.

@slinkydeveloper
Copy link
Contributor Author

For now I scope out the cancelling state, as this is not the same as killing:

  • A cancelling invocation can be either invoked or suspended
  • A killing invocation can transition only from invoked. There is no need for "suspended killing" state at all, because the transition is executed immediately

@slinkydeveloper slinkydeveloper changed the title Introduce Cancelling/Killing invocation status variants Introduce Cancelling invocation status variants Nov 21, 2024
@slinkydeveloper slinkydeveloper changed the title Introduce Cancelling invocation status variants Introduce Killed invocation status variants Nov 21, 2024
@slinkydeveloper slinkydeveloper changed the title Introduce Killed invocation status variants Introduce Killed invocation status variant Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant