From 2714c9bfc99073318e3b3a25c84d6e47f4ce918d Mon Sep 17 00:00:00 2001 From: Giselle van Dongen Date: Thu, 1 Feb 2024 12:39:12 +0100 Subject: [PATCH] Feedback --- README.md | 9 +++++---- typescript/dynamic-workflow-executor/README.md | 2 ++ 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index 649d24e4..40ee6bee 100644 --- a/README.md +++ b/README.md @@ -64,6 +64,7 @@ For running Restate locally and downloading the binaries, have a look at the opt - To run Restate with Homebrew: ``` brew install restatedev/tap/restate-server + restate-server ``` ### Register the deployment in Restate @@ -72,14 +73,14 @@ Once Restate is up, register the deployment in Restate by executing: - Via the [CLI](https://docs.restate.dev/restate/cli): ```shell - restate dp register http://host.docker.internal:9080 + restate dp register localhost:9080 ``` - When running Restate with Docker, use `host.docker.internal` instead of `localhost` for the service deployment URI. - Via `curl`: ```shell - curl localhost:9070/deployments -H 'content-type: application/json' -d '{"uri": "http://host.docker.internal:9080"}' + curl localhost:9070/deployments -H 'content-type: application/json' -d '{"uri": "http://localhost:9080"}' ``` - When running Restate with Docker, use `host.docker.internal` instead of `localhost` for the service deployment URI. + +When running Restate with Docker, use `host.docker.internal` instead of `localhost` for the service deployment URI. This should give you the following output in case of the ticket reservation example: ```json diff --git a/typescript/dynamic-workflow-executor/README.md b/typescript/dynamic-workflow-executor/README.md index 4caed660..6c40255a 100644 --- a/typescript/dynamic-workflow-executor/README.md +++ b/typescript/dynamic-workflow-executor/README.md @@ -78,6 +78,8 @@ npm run workflow-service Now [launch the Restate Server](../../README.md#launching-the-restate-server) and [register the services](../../README.md#register-the-deployment-in-restate). +Make sure you register all four services with the following ports: `9080`, `9081`, `9082` and `9083`. + ### OPTIONAL: Install and run stable diffusion server **Note:** You can run this demo without Stable Diffusion. In that case, you cannot use workflow steps that call Stable Diffusion.