Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expression delimiters cannot use the dollar sign ($) #23

Open
msssk opened this issue Oct 9, 2017 · 3 comments
Open

Expression delimiters cannot use the dollar sign ($) #23

msssk opened this issue Oct 9, 2017 · 3 comments

Comments

@msssk
Copy link

msssk commented Oct 9, 2017

Since ${expr} has become the standard for JS template strings it seems it would be nice to be able to use the same syntax in HTML templates. However, it doesn't work with reshape (perhaps owing to reshape's own use of ${expr} in processing templates).

Test: set delimiters to [ '${', '}' ]
Result: tokens are not replaced

I didn't test extensively, but trying several combinations including the dollar sign, none of them worked.

@jescalan
Copy link
Member

Weird! Is it just the dollar sign, or anything? I have tested this with a variety of other delimiters and it has worked fine. If you could narrow it down to the characters specifically causing the issue, this would help a lot.

@Elbone
Copy link

Elbone commented Feb 20, 2018

@msssk Did you ever get to the bottom of this? I'm having a similar issue with your reshape-component plugin.

@msssk
Copy link
Author

msssk commented Feb 20, 2018

I didn't, I've just been getting by without changing the delimiters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants