Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include react^17 as peerDeps #205

Closed
wants to merge 2 commits into from

Conversation

inbeom
Copy link

@inbeom inbeom commented Jul 1, 2021

Description

Added react^17 and react-dom^17 as peer dependencies.

Motivation and context

This fixes #199

How has this been tested?

Screenshots (if relevant):

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have added tests to cover my changes
  • All new and existing tests passed

Sorry, something went wrong.

@benmneb
Copy link

benmneb commented Aug 15, 2021

any reason why this hasnt been accepted yet?

@stefanhoth
Copy link
Contributor

@inbeom Apologies for the delays and thanks for your contribution. We're a bit behind in keeping this repo up-to-date so we appreciate the help! Could you rebase your branch so it's mergeable again, please?

@stefanhoth
Copy link
Contributor

Our dependency-bot issued #196 and this has been merged now.

@stefanhoth stefanhoth closed this Sep 9, 2021
@emielvangoor
Copy link

How can i install this when using React 17+ ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support React 17; update peerDependencies
4 participants