Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query In <-> Contains #5

Open
Estartu opened this issue Apr 6, 2016 · 2 comments
Open

Query In <-> Contains #5

Estartu opened this issue Apr 6, 2016 · 2 comments

Comments

@Estartu
Copy link

Estartu commented Apr 6, 2016

There is a inconsistency in the Query and the Indexes.

Keywordindex and FacetIndex define a In Query but in query.py no such Query is defined. There is the Contains Query but it's not implemented in any indexes.

I Think the In Query in die Indexes should be renamed to Contains

@tseaver
Copy link
Member

tseaver commented Apr 6, 2016

Thank you for the report! Confusingly, query.Contains is mapped from the in keyword in a query expression, e.g.:

'abc' in some_index_name

That confusion is probably why indexes.keyword.CatalogKeywordIndex defines applyIn as an alias for applyContains I believe that your conclusion is correct: that alias should be applyContains instead.

There is the Contains Query but it's not implemented in any indexes.

It looks like indexes.text.CatalogTextIndex is the only one which implements applyContains.

@tseaver
Copy link
Member

tseaver commented Apr 6, 2016

@chrisrossi PTAL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants