[#442] Replace CommandRunner with JGit for GitBranch #1454
Conversation
CommandRunner should be deprecated and replaced by JGit as it requires Git to be installed and has poor exception handling. JGit is able to handle Git operations natively, which makes it more robust to use. Let's replace usages of CommandRunner with their equivalents in JGit, starting with GitBranch.
| @@ -68,11 +68,18 @@ public RepoLocation getClonedRepoLocation() { | |||
| String bareRepoPath = FileUtil.getBareRepoPath(configs[currentIndex]).toString(); | |||
| currentRepoDefaultBranch = GitBranch.getCurrentBranch(bareRepoPath); | |||
| } catch (GitBranchException gbe) { | |||
| // GitBranch will throw this exception when repository is empty | |||
| logger.log(Level.WARNING, String.format(MESSAGE_ERROR_GETTING_BRANCH, | |||
There was a problem hiding this comment.
Why do we need this given you have added code for this already? Or did you forget to remove it?
There was a problem hiding this comment.
I didn't remove this exception handling as I think that there might be some other errors that may occur. For instance, GitBranchException is thrown because an IOException occurred, which probably happened if the directory given is not a Git repository (which shouldn't happen).
|
Good to do a light exploration of this direction at first before going hard at it. For example, we can try to get it working first before deciding whether to merge (hence, no need for a detailed review of the PR first) |
|
I have updated my original comment in #442 with a pros and cons list based on the research that I have done on JGit, so that we can make a more informed decision. |
|
As the discussion, I will make it |
Part of #442.
This PR is a proof-of-concept of what JGit can potentially do, instead of relying on CommandRunner.