Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Vue CLI with Vite #2176

Open
sopa301 opened this issue Mar 28, 2024 · 2 comments · Fixed by #2178
Open

Replace Vue CLI with Vite #2176

sopa301 opened this issue Mar 28, 2024 · 2 comments · Fixed by #2178
Assignees
@sopa301
Labels
a-DevOps a-FrontEnd c.Feature

Comments

@sopa301
Copy link
Contributor

sopa301 commented Mar 28, 2024 •
edited
Loading

What feature(s) would you like to see in RepoSense

Replace Vue CLI with Vite. There are many benefits to doing so.

Is the feature request related to a problem?

  • vue/component-compiler-utils (a dependency of Vue CLI) has a few security issues that have yet to be resolved and is unlikely to be resolved soon.
  • Vue CLI itself is being put on maintenance mode.

If possible, describe the solution

Install Vite and remove Vue CLI.

Additional context

Migration guide.
#2143 for more information and things to take note of.
@ckcherry23
Copy link
Member

Do we need create-vue if we are migrating from an existing project instead of creating a starter boilerplate? Maybe the title should be "Replace Vue CLI with Vite" instead?

@sopa301 sopa301 changed the title Replace Vue CLI with create-vue Replace Vue CLI with Vite Mar 29, 2024
@sopa301 sopa301 mentioned this issue Mar 29, 2024
Merged
@sopa301 sopa301 self-assigned this Apr 2, 2024
ckcherry23 pushed a commit that referenced this issue May 12, 2024
@sopa301
[#2176] Move from Vue CLI to Vite (#2178)
20526f4 
Move from Vue CLI to Vite

Vue CLI has been put on maintenance mode and its dependencies have
security issues that have not been fixed for a while. Switching to Vite
also allows us to introduce Vitest for our unit testing.

Let's install Vite and remove Vue CLI.
@github-project-automation github-project-automation bot moved this to Closed/Completed in RepoSense Roadmap May 12, 2024
ckcherry23 added a commit that referenced this issue May 13, 2024
@ckcherry23
Revert "[#2176] Move from Vue CLI to Vite (#2178)"
ffee291 
This reverts commit 20526f4.
@ckcherry23 ckcherry23 reopened this May 14, 2024
@ckcherry23
Copy link
Member

Let's ensure the Vite migration allows the RepoSense report to be deployed on GitHub pages (see #2202).

Since GitHub pages deployment seems to be an integral part of the RepoSense workflow, it may be worth setting up tests for the deployment itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sopa301 sopa301

Labels
a-DevOps a-FrontEnd c.Feature
Projects
RepoSense Roadmap
Status: Closed/Completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#2176] Move from Vue CLI to Vite sopa301/RepoSense
2 participants
@ckcherry23 @sopa301