Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move CSS for Segment component into c-segment.vue #2112

Closed
sopa301 opened this issue Feb 16, 2024 · 0 comments · Fixed by #2113
Closed

Move CSS for Segment component into c-segment.vue #2112

sopa301 opened this issue Feb 16, 2024 · 0 comments · Fixed by #2113
Assignees
@sopa301
Labels
a-CodeQuality a-FrontEnd

Comments

@sopa301
Copy link
Contributor

sopa301 commented Feb 16, 2024

What feature(s) would you like to see in RepoSense

The CSS for c-segment is currently located in c-authorship-file.vue. We should move it into segment.vue.

Is the feature request related to a problem?

No, but it may be troublesome to edit the styling for the segment component if it remains in a separate file.

If possible, describe the solution

Copy the relevant code over to segment.vue.

If applicable, describe alternatives you've considered

NIL

Additional context

Original discussion in #2096.
@sopa301 sopa301 self-assigned this Feb 16, 2024
@sopa301 sopa301 mentioned this issue Feb 16, 2024
Merged
ckcherry23 pushed a commit that referenced this issue Feb 19, 2024
@sopa301
[#2112] Move Segment CSS into c-segment.vue (#2113)
fdb1892 
The segment component CSS currently resides in the c-authorship-file
component. Moving it to the segment component would make it easier to
edit the segment component in the future.

Let's move the CSS into c-segment.vue.
@github-project-automation github-project-automation bot moved this to Closed/Completed in RepoSense Roadmap Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sopa301 sopa301

Labels
a-CodeQuality a-FrontEnd
Projects
RepoSense Roadmap
Status: Closed/Completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#2112] Move Segment CSS into segment.vue sopa301/RepoSense
2 participants
@ckcherry23 @sopa301