Fix #15 and upgrade dependencies

repocrypts · Jul 28, 2020 · 3d45e0c · 3d45e0c
1 parent 9585ad5
commit 3d45e0c
Show file tree

Hide file tree

Showing 5 changed files with 27 additions and 17 deletions.
diff --git a/dist/Validator.js b/dist/Validator.js
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
     "name": "Validator",
-    "version": "1.1.0",
+    "version": "1.1.1",
     "description": "A JavaScript validation package, based on Laravel validation.",
     "main": "dist/Validator.js",
     "scripts": {

diff --git a/src/validator.js b/src/validator.js
@@ -201,6 +201,10 @@ class Validator {
         this.errors = {};
         this.failedRules = {};
 
+        if (this.isEmptyObject(this.data)) {
+            return true;
+        }
+
         this.rules.forEach(function (item) {
             let name = item.name;
 

diff --git a/test/validator.js b/test/validator.js
@@ -290,6 +290,12 @@ describe('Validator', () => {
             expect(v.fails()).to.be.false;
             expect(v.invalid()).to.be.empty;
         });
+
+        it('should not fail if data is defined as an empty object', () => {
+            let v = Validator.make({}, { date: 'date' });
+
+            expect(v.fails()).to.be.false;
+        });
     });
     describe('#getErrors()', () => {
         const rules = {
@@ -334,7 +340,7 @@ describe('Validator', () => {
 
     describe('#validateRequired()', () => {
         it('return false when the required field is not present', () => {
-            const v = Validator.make({}, { name: 'required' });
+            const v = Validator.make({ field: 'data' }, { name: 'required' });
             expect(v.passes()).to.be.false;
         });
 
@@ -827,7 +833,7 @@ describe('Validator', () => {
         });
 
         it('returns false when the field is not present', () => {
-            const v = Validator.make({}, rules);
+            const v = Validator.make({ field: {} }, rules);
             expect(v.passes()).to.be.false;
         });
 
@@ -1435,7 +1441,7 @@ describe('Validator', () => {
         });
 
         it('returns false when the data is empty (the field under validation is not present)', () => {
-            const v = Validator.make({}, rules);
+            const v = Validator.make({ field: 'data' }, rules);
             expect(v.passes()).to.be.false;
         });
 
@@ -1453,7 +1459,7 @@ describe('Validator', () => {
                 f2: 'required_without:f1,f3',
                 f3: 'required_without:f1,f2',
             };
-            const v = Validator.make({}, rules);
+            const v = Validator.make({ field: 'data' }, rules);
             expect(v.fails()).to.be.true;
 
             v.setData({ f1: 'foo' }, rules);
@@ -1487,7 +1493,7 @@ describe('Validator', () => {
         };
 
         it('returns false when given data is empty', () => {
-            const v = Validator.make({}, rules);
+            const v = Validator.make({ field: 'data' }, rules);
             expect(v.fails()).to.be.true;
         });
 
@@ -1608,7 +1614,7 @@ describe('Validator', () => {
         });
     });
 
-    describe('# Error Messages', () => {
+    describe('#Error Messages', () => {
         const rules = {
             name: 'required|min:3',
             age: 'numeric|min:20',
@@ -1649,14 +1655,14 @@ describe('Validator', () => {
         });
     });
 
-    describe('# Others', () => {
+    describe('#Others', () => {
         it('tests that empty rules are skipped', () => {
             const v = Validator.make({ x: 'asksksks' }, { x: '|||required|' });
             expect(v.passes()).to.be.true;
         });
     });
 
-    describe('# Custom Names', () => {
+    describe('#Custom Names', () => {
         const customNames = {
             name: 'Name',
             age: 'Age',
@@ -1673,7 +1679,7 @@ describe('Validator', () => {
         };
 
         it('tests custom name being applied using constructor', () => {
-            const v = Validator.make({}, rules, {}, customNames);
+            const v = Validator.make({ field: 'name' }, rules, {}, customNames);
             expect(v.passes()).to.be.false;
             expect(v.getErrors()).to.deep.equal(expectedResult);
         });
@@ -1693,7 +1699,7 @@ describe('Validator', () => {
         });
     });
 
-    describe('# Custom Messages', () => {
+    describe('#Custom Messages', () => {
         const rules = {
             name: 'required',
             age: 'required',
@@ -1737,7 +1743,7 @@ describe('Validator', () => {
         });
     });
 
-    describe('# Displayable values are replaced', () => {
+    describe('#Displayable values are replaced', () => {
         it('tests required_if:foo,bar', () => {
             const v = Validator.make(
                 { color: '1', bar: '' },
@@ -1785,7 +1791,7 @@ describe('Validator', () => {
         });
     });
 
-    describe('# nullable rule tests', () => {
+    describe('#validateNullable', () => {
         it('should passed a empty date with "nullable" rule', () => {
             const v = Validator.make(
                 {

diff --git a/yarn.lock b/yarn.lock
@@ -1382,9 +1382,9 @@ ecc-jsbn@~0.1.1:
     safer-buffer "^2.1.0"
 
 electron-to-chromium@^1.3.488:
-  version "1.3.509"
-  resolved "https://registry.yarnpkg.com/electron-to-chromium/-/electron-to-chromium-1.3.509.tgz#830fcb89cd66dc2984d18d794973b99e3f00584c"
-  integrity sha512-cN4lkjNRuTG8rtAqTOVgwpecEC2kbKA04PG6YijcKGHK/kD0xLjiqExcAOmLUwtXZRF8cBeam2I0VZcih919Ug==
+  version "1.3.510"
+  resolved "https://registry.yarnpkg.com/electron-to-chromium/-/electron-to-chromium-1.3.510.tgz#dee781ff8b595c0deb60172b75d50b6889757eda"
+  integrity sha512-sLtGB0znXdmo6lM8hy5wTVo+fLqvIuO8hEpgc0DvPmFZqvBu/WB7AarEwhxVKjf3rVbws/rC8Xf+AlsOb36lJQ==
 
 emoji-regex@^7.0.1:
   version "7.0.3"