Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: file download time and throughput is not accurate #71

Open
Tracked by #67
tempusfrangit opened this issue Dec 3, 2023 · 0 comments
Open
Tracked by #67

Bug: file download time and throughput is not accurate #71

tempusfrangit opened this issue Dec 3, 2023 · 0 comments
Labels
bug Something isn't working
Milestone

Comments

@tempusfrangit
Copy link
Member

With the recent changes download timings are no longer accurate for time spent downloading an individual file in multifile mode.

This is related to some chunks blocking on connections so download_elapsed is effectively total_elapsed in all cases.

  • Pget should have a way of communicating time spent for a chunk and aggregating it for a given file rather than download_elapsed including blocking time. This also breaks the throughput calculation.

  • An alternative is to explore downloading one file at a time and allocating connections to meet the target chunk size before moving on to the next file.

If we go with communicating the download time up the stack, this feels like a legitimate use for values in the context (pointer to per-chunk data) instead of trying to pass data back up the whole stack.

@tempusfrangit tempusfrangit changed the title Rework timing for download Bug: file download time and throughput is no linger accurate Dec 3, 2023
@tempusfrangit tempusfrangit changed the title Bug: file download time and throughput is no linger accurate Bug: file download time and throughput is not accurate Dec 3, 2023
@tempusfrangit tempusfrangit added this to the 1.0.0 milestone Dec 3, 2023
@tempusfrangit tempusfrangit added the bug Something isn't working label Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant