Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Undefined wallet login in Nova wallet browser #3473

Closed
noahjoeris opened this issue Dec 16, 2024 · 7 comments
Closed

[bug] Undefined wallet login in Nova wallet browser #3473

noahjoeris opened this issue Dec 16, 2024 · 7 comments
Labels
bug Something isn't working

Comments

@noahjoeris
Copy link

Link to minimal reproducible example

https://app.turtle.cool

Summary

Reproduce:
Open https://app.turtle.cool inside the nova embedded browser. Connect Ethereum wallet. Undefined popup should appear.
See the video below for a demo (popup at 25s).
https://github.com/user-attachments/assets/e1fcaf57-d600-4e3a-9369-28d22afa207b

Info:

  • It seems to happen only inside the nova browser.
  • Disconnecting and connecting again make it work.
  • This console error might be related:
    image

List of related npm package versions

"@reown/appkit": "^1.5.3",
"@reown/appkit-adapter-wagmi": "^1.5.3",
"wagmi": "^2.13.3",

Node.js Version

v20.10.0

Package Manager

[email protected]

@noahjoeris noahjoeris added bug Something isn't working needs review labels Dec 16, 2024
Copy link

linear bot commented Dec 16, 2024

Copy link

Thanks for reporting - we will pick this up!

@linear linear bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 16, 2024
@rtomas
Copy link
Contributor

rtomas commented Dec 16, 2024

This is a duplicate bug known issue ... but I'm keeping open

@rtomas rtomas reopened this Dec 16, 2024
@arein
Copy link
Contributor

arein commented Dec 17, 2024

I believe we fixed this in 1.6.0 - thanks for reporting - btw @noahjoeris https://app.turtle.cool/ is loading very slowly for me - maybe the background image is too large

@noahjoeris
Copy link
Author

Thanks a lot for the help. Upgrading to 1.6.0 fixed it 👍 Also appreciate letting us know of the performance issues, we are aware of this and working on a fix :)

@noahjoeris
Copy link
Author

@arein FYI after updating we now receive a new error. But it doesn't impact the functionality fortunately.
image
image

It happens when connecting an ethereum wallet and then reloading the page. So maybe some persistence issue.

@noahjoeris noahjoeris reopened this Dec 17, 2024
@rtomas
Copy link
Contributor

rtomas commented Dec 17, 2024

hi @noahjoeris ! Closing the issue. please open a new one for the new error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants