-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add validation for docker-cmd-file #822
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i've updated a little, so you only need to do the async implementation
thanks for that, I added the async implementation |
(s.mode & fs.constants.R_OK) === 0 || | ||
(s.mode & fs.constants.X_OK) === 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(s.mode & fs.constants.R_OK) === 0 || | |
(s.mode & fs.constants.X_OK) === 0 | |
(s.mode & (fs.constants.R_OK | fs.constants.X_OK)) === 0 |
isn't this simpler?
please use the re-request review button on PR to get another review |
Marked as draft due to inactivity. |
related to #817