From d3c01a9d146594a56b07ab551b7633893aab141b Mon Sep 17 00:00:00 2001 From: Stephen Cuppett Date: Sat, 2 Dec 2023 07:39:23 -0500 Subject: [PATCH] Avoid suppressed JSON error here. --- src/Traits/Cluster/ChecksClusterVersion.php | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/Traits/Cluster/ChecksClusterVersion.php b/src/Traits/Cluster/ChecksClusterVersion.php index 873022f..ba06cfa 100644 --- a/src/Traits/Cluster/ChecksClusterVersion.php +++ b/src/Traits/Cluster/ChecksClusterVersion.php @@ -6,6 +6,7 @@ use Composer\Semver\VersionParser; use GuzzleHttp\Exception\ClientException; use GuzzleHttp\Exception\GuzzleException; +use JsonException; use RenokiCo\PhpK8s\Exceptions\KubernetesAPIException; trait ChecksClusterVersion @@ -21,6 +22,7 @@ trait ChecksClusterVersion * @return void * * @throws KubernetesAPIException|GuzzleException + * @throws JsonException */ protected function loadClusterVersion(): void { @@ -42,7 +44,7 @@ protected function loadClusterVersion(): void ); } - $json = @json_decode($response->getBody(), true); + $json = json_decode($response->getBody(), true, 512, JSON_THROW_ON_ERROR); $parser = new VersionParser(); $this->kubernetesVersion = $parser->normalize($json['gitVersion']);