You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This came from the one to one match of the markup version:
<a11y-vue-dialog-renderless#default="{ backdropRef }"><!-- i work as root but also as backdrop overlay --><divclass="dialog" v-bind="backdropRef.props"><divclass="dialog__inner">conent</div><div></div>
But this is also a valid implementation, and currently will break the component
<a11y-vue-dialog-renderless#default="{ backdropRef }"><!-- i work as root --><divclass="dialog"><divclass="dialog__backdrop" v-bind="backdropRef.props" /><divclass="dialog__inner">conent</div><div></div>
Cause
Our dom "refs", are querySelected assuming a dialogRoot exists and is the element with data-id, but that data-id is bound via backdropRef.props, meaning it won't find the descendents.
This came from the one to one match of the markup version:
But this is also a valid implementation, and currently will break the component
Cause
Our dom "refs", are
querySelected
assuming a dialogRoot exists and is the element withdata-id
, but thatdata-id
is bound viabackdropRef.props
, meaning it won't find the descendents.a11y-vue-dialog/src/A11yVueDialogRenderless.vue
Lines 176 to 188 in 34f5985
The text was updated successfully, but these errors were encountered: