Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dialogRef flaky specs #18

Open
renatodeleao opened this issue Apr 29, 2020 · 1 comment
Open

fix: dialogRef flaky specs #18

renatodeleao opened this issue Apr 29, 2020 · 1 comment
Labels
help wanted Extra attention is needed test:unit

Comments

@renatodeleao
Copy link
Owner

Although things are working i can't seem to write a proper test to check if methods are being called correctly.

@renatodeleao renatodeleao added help wanted Extra attention is needed test:unit labels Apr 29, 2020
@renatodeleao
Copy link
Owner Author

/**
* And yet i finally found the reason for my method tests to be failing
* I was mocking the wrapper component, not The component itsel
* 🤦‍♂️
* @todo // [1]
*/
const MockedA11yVueDialogRenderless = {
...A11yVueDialogRenderless,
methods: {
...A11yVueDialogRenderless.methods,
_isVisible: mockIsVisible
}
}

Note to self.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed test:unit
Projects
None yet
Development

No branches or pull requests

1 participant