Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more statistics #193

Closed
tilmanginzel opened this issue Jun 1, 2020 · 12 comments
Closed

Add more statistics #193

tilmanginzel opened this issue Jun 1, 2020 · 12 comments

Comments

@tilmanginzel
Copy link
Contributor

Hey,

I was wondering if we could a few more statistics for the report generation (see AOEpeople/geb-spock-reports#17). Below I list all currently available statistics, and the ones which could be added:

Summary Report:

  • Currently available:
    • Total Specifications
    • Passed Specifications
    • Failed Specifications
    • Specification Success Rate
    • Total Feature Failures
    • Total Feature Errors
    • Total Execution Time
  • Missing:
    • Ignored Specifications
    • Total Features Passed
    • Total Features Success Rate

Specification Report:

  • Currently available:
    • Feature Failures
    • Feature Errors
    • Features Skipped
    • Total Runs
    • Total Features
    • Success Rate
    • Execution Time
  • Missing:
    • Passed Features

What do you think? Maybe I could try to provide a pull request for this if you want.

Cheers :)

@renatoathaydes
Copy link
Owner

Hm, aren't all the missing statistics derived from the existing ones?

@tilmanginzel
Copy link
Contributor Author

Yes, I think all of them can be simply derived one way or another. It just seems cleaner to have them directly available in the Utils.stats and Utils.aggregateStats methods.

@renatoathaydes
Copy link
Owner

We're currently trying to fix the problem with skipped features (or feature iterations) not being shown properly in #191. I will try to add these as we get that fixed.

@tilmanginzel
Copy link
Contributor Author

tilmanginzel commented Jun 1, 2020

Sounds good, thanks! I was already wondering if that pull request might be related and will continue to keep an eye on it.

@ShubhenduPandey
Copy link

Hi @renatoathaydes
By making below changes in "Map aggregateStats" I was able to achieve total feature run count and total pass
Screenshot of before and after a code change
Screenshot
Report Screenshot
report screenshot

Can you please make changes to the code, Our requirement is to show the total feature and total pass/fail count
I was not able to override your method and use it my project, So I guess I have to wait till you make the changes.

@renatoathaydes
Copy link
Owner

@ShubhenduPandey you seem to be misunderstanding what the reports show.

Total in the specifications summary report is the total number of specifications, not features.

Passed refers to the number of specifications that passed, not features.

Each specification has a feature report, where you can find details about the features.

As far as I can see, this is unrelated to this ticket anyway, please create a new ticket if you still feel like something should be added/changed in the existing reports.

@ShubhenduPandey
Copy link

ShubhenduPandey commented Sep 10, 2020

@renatoathaydes I was hoping report to look something like below
screenshot16_06_39

@renatoathaydes
Copy link
Owner

@ShubhenduPandey you can provide custom CSS files to make the report look like this. To change the actual data in the reports, you can create your own template.

@renatoathaydes
Copy link
Owner

I've decided to just add all statistics requested in the issue's description.

Please have a look at the modified reports I am thinking of releasing soon, which include some of the new stats:

Specs summary report

Spec features report

@tilmanginzel
Copy link
Contributor Author

Thanks @renatoathaydes, looks good to me. 👍

renatoathaydes added a commit that referenced this issue Oct 4, 2020
Fixed HTML tables missing tr inside thead.
@renatoathaydes
Copy link
Owner

Finally, this has been fixed in version 1.8.0!!

Please look at the README page on branch 1.7.x for the updated docs while I don't release again with the master branch, while it's at the 2.0-RC version.

@tilmanginzel
Copy link
Contributor Author

Awesome, thank you. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants